Avoid using cliclack.confirm in non-interactive session #6412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #6236 by preventing cliclack.confirm prompts from being called in non-interactive sessions, which would cause hangs or failures in automated environments like goose term or CI/CD.
Key changes:
- Added
interactiveparameter tocheck_missing_extensions_or_exitfunction - Added conditional logic to skip interactive prompts when
session_config.interactiveis false - Non-interactive sessions now emit warnings to stderr and continue execution instead of prompting
DOsinga
approved these changes
Jan 9, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
We could consider at some point to have a utility that would take the question and the warning and the default value and then in non-interactive mode print the warning and assume the default, but let's go with this!
| process::exit(0); | ||
| } | ||
| } else { | ||
| // Non-interactive mode: warn and continue without missing extensions |
Collaborator
There was a problem hiding this comment.
can you remove the comment?
lifeizhou-ap
deleted the
lifei/fix-resume-with-different-working-dir-non-interactive
branch
zanesq
added a commit
that referenced
this pull request
Jan 12, 2026
…ased * 'main' of github.com:block/goose: chore: break up process agent response (#6348) More 3.7 removal (#6414) CLI show extension errors (#6398) fix[desktop]: Improve UX for ExtensionItem component (#6443) update[doc]: Add tip for GitHub Copilot Provider (#6441) Avoid using cliclack.confirm in non-interactive session (#6412) docs: claude prompt caching note (#6429) Restore task completion notification (#6427) docs: stream-json and auth-token cli options (#6426)
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 13, 2026
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #6236
Type of Change
AI Assistance
Testing
Manual testing